[9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Hamlin Li huaming.li at oracle.com
Wed Sep 28 03:24:41 UTC 2016

Hi Brent,

Thank you for reviewing.
Please check the new webrev: 
http://cr.openjdk.java.net/~mli/8085192/webrev.01/, and comments inline 

On 2016/9/28 2:07, Brent Christian wrote:
> Thanks for making some improvements to these intermittent RMI tests.
> I agree with Roger that I don't think we want to add the id to the 
> @bug of every test.
Yes, I think it's reasonable too. Fixed.
> Also, it looks like there's an indentation change in JavaVM.java:
> 53         public static final long POLLTIME_MS = 100L;
> (I believe running webrev with '-b' will include whitespace changes.)
Fixed, thank you for the tip, new webrev is generated with "-b". :-)

Thank you
> Thanks,
> -Brent
> On 9/27/16 2:22 AM, Hamlin Li wrote:
>> Please review the fix for JDK-8085192. The fix checks whether it fails
>> to launch rmid due to "Port already in use" error, it will launch rmid
>> again and again(20 times at most) until no such issue.
>> bug:
>>     https://bugs.openjdk.java.net/browse/JDK-8085192
>> webrev:
>>     http://cr.openjdk.java.net/~mli/8085192/webrev.00/
>> Thank you
>> -Hamlin

More information about the core-libs-dev mailing list