RFR: JDK-8185994: Fix a11y and HTML issues in the java.base/java.io and java.base/java.nio packages

Brian Burkhalter brian.burkhalter at oracle.com
Thu Aug 10 20:00:22 UTC 2017

On Aug 9, 2017, at 6:56 PM, Stuart Marks <stuart.marks at oracle.com> wrote:

> On 8/9/17 5:14 PM, Jonathan Gibbons wrote:
>> Please review this proposed change to address accessibility and HTML issues
>> in the java.base java.io and java.nio[.*] packages.
>> In general, the changes consist of
>> * update tables to add scope=row|col as appropriate.
>>    In some cases, slightly more surgery was needed on the table
>> * fix issues reported by tidy
>>    In most cases, this is removing superfluous <p> elements.
>> Webrev: http://cr.openjdk.java.net/~jjg/8185994/webrev.00/index.html
>> API: http://cr.openjdk.java.net/~jjg/8185994/api.00/index.html
> Again, changes mostly look good. One small formatting point on DataInput. The numbers in the table should all have similar alignment. Most of the numbers in the table body look centered. I think it would look better if the numbers in the "Bit Values" column headers, and the numbers in the Byte column, were all centered. Since they're all single digits, you can probably get away with centering (unless you want to change them all to right-aligned with padding, or something).

I concur with Stuart that this is the only problem area. Centering the Byte column would be good for sure. Centering the “Bit Values” entries “bits x-y” could work if they were aligned in a visually appealing manner, e.g., centered with respect to the same vertical. Another possibility would be to have a separate cell for each row-column position and put “b6”, “b5”, etc. in the cells perhaps with a footnote below the table about the notation unless it’s deemed obvious (maybe use subscript elements b<sub>6</sub>, etc.?).


More information about the core-libs-dev mailing list