RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

David Holmes david.holmes at oracle.com
Fri Aug 11 04:22:27 UTC 2017

Hi Igor,

On 11/08/2017 2:02 PM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html
>> 14 lines changed: 1 ins; 0 del; 13 mod;
> Hi all,
> could you please review this small patch which bumps up jtreg version?
> besides updating jib profiles and all TEST.ROOT files, 

That all looks fine (though deploy should not be in there).

> the fix updates
> hotspot/test/runtime/Metaspace/FragmentMetaspaceSimple.java test not to
> rely on having "library" test.Empty class in 'test.classes' and put
> test.Empty class in the workdir instead.

Sorry I'm not following this part. You made two changes:

1. Added @library /test/lib

What is this doing? (For that matter what is the existing "classes" 
entry supposed to mean ??? how is "classes" a library?)

2. Instead of the test reading from test.classes you are using the 
ClassfileInstaller to copy the class to the working directory.

How does this make a difference to anything? If the test wouldn't find 
the class in test.classes, doesn't that mean ClassfileInstaller will 
also fail to find it?


> testing: :hotspot_all, {jdk,langtools,nashorn,jaxp}/test/:tier[1-3]
> Thanks,
> -- Igor

More information about the core-libs-dev mailing list