RFR(s): 8174194: Several java/lang tests failing due to undeclared module dependencies.

Sergei Kovalev sergei.kovalev at oracle.com
Wed Feb 8 14:13:42 UTC 2017

Hi Daniel,

Thank you for review.

> Hi Sergey,
> LFMultiThreadCachingTest.java
> Can you clarify the change in this file?
> jdk.management requires java.management - so if the test failed with
> --limit-modules when it required jdk.management then it's not going to
> pass if it is changed to require only java.management.
> Or is it that jdk.management was actually not required and the
> test was passing all right because it only required java.management?
Actually jdk.management is not required for this particular test. 
java.management module is enough to pass the test.
> The other files look OK, I guess.
> best regards,
> -- daniel
> On 08/02/17 13:51, Sergei Kovalev wrote:
> >/Hi Team, />//>/Please review small fix for test suite regarding module dependency. />//>/BugID: https://bugs.openjdk.java.net/browse/JDK-8174194 />/WebRev: http://cr.openjdk.java.net/~skovalev/8174194/webrev.00/ 
> <http://cr.openjdk.java.net/%7Eskovalev/8174194/webrev.00/> />//

With best regards,

More information about the core-libs-dev mailing list