RFR: 8174735 Update JAX-WS RI integration to latest version

Lance Andersen lance.andersen at oracle.com
Tue Feb 14 20:28:50 UTC 2017

Hi Roman,

I made a pass through the changes.  And here are some general comments which are mostly minor in nature….


	- The comment “If true, despite of the specification….”;  This does not read well can this be clarified?

Generated.java, PostConstruct.java, PreDestroy.java,Resource.java
         -  Be nice to use {@code} vs <code></code> for readability
         -  Do you really need <p></p>?  I am assuming there are no doclint errors on Generated?
         - Was there a CCC for the changes as there were some minor semantic updates

       - createMimeBodyPart @param len does not align properly

       - writeTo @param out does not align

       -  Some comments have a blank line before the params, others do not.  It would be nice to be consistent

       - Can you explain the status regarding returnParser() and https://jaxp.dev.java.net/issues/show_bug.cgi?id=59
       - getSystemClassLoader, do you really need to check for a SecurityManager?  Why not just AccessController.doPrivilege(could also use a lambda also)

       - Looks like the alignment is off in the changes in invoke

        -  getContextClassLoader could be changed to use a lambda with AccessController.doPrivilege if you desire

       - getSystemProperty, it looks like you were using a lambda and removed it for the AccessController.doPrivilege?

      - same comment as SAAJUtil.java
      - copyLocater, createValidationContext @return comment needs checked 

      - Seem the new files include a 2003/2004/1997, 2017, copyright, should just be 2017 i believe

> On Feb 14, 2017, at 7:00 AM, Roman Grigoriadi <roman.grigoriadi at oracle.com> wrote:
> Hi,
> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8174735
> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/00/
> You can find change list in the description of JBS and its linked issues. Most diffs are for SAAJ-RI related to JDK-8166745 - remove dependencies on jdks Xerces internal classes.
> Thanks,
> Roman

 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>

More information about the core-libs-dev mailing list