RFR(XS): 8183534: [TEST] Make detection of compilation mode more robust
volker.simonis at gmail.com
Wed Jul 5 14:46:02 UTC 2017
thanks for your review.
On Wed, Jul 5, 2017 at 11:33 AM, Langer, Christoph
<christoph.langer at sap.com> wrote:
> Hi Volker,
> overall, the change looks good to me.
> When you create the Exception to print the stack trace (line 129 in the new file), why not add the value of 'java.vm.info' to the message?
Good point. I'll do so.
> Also, I don't like the spaces around the '.' before PrintStackTrace() - but maybe that's just my personal taste. ;-)
You're right. I somehow thought that the spaces are the default
"coding style" for OpenJDK but I've checked and you're right that by
default we don't use spaces when calling a method right on a 'new'
expression. I'll update the change accordingly.
> Best regards
>> -----Original Message-----
>> From: core-libs-dev [mailto:core-libs-dev-bounces at openjdk.java.net] On
>> Behalf Of Volker Simonis
>> Sent: Dienstag, 4. Juli 2017 11:05
>> To: HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>;
>> Java Core Libs <core-libs-dev at openjdk.java.net>
>> Subject:  RFR(XS): 8183534: [TEST] Make detection of compilation mode
>> more robust
>> can you please review the following trivial change which makes the
>> detection of compilation mode for JTreg more robust:
>> The compilation mode in JTreg is parsed from the "java.vm.info" system
>> property. The current implementation expects that "java.vm.info"
>> contains exactly one of the strings "mixed mode", "compiled mode" or
>> "interpreted mode" otherwise the detection will fail and JTreg will
>> quit with an error.
>> The detection can be done more robust by searching for the substrings
>> "mixed mode", "compiled mode" or "interpreted mode" instead, thus
>> allowing OpenJDK builders to store additional information in the
>> "java.vm.info" system property.
>> Thank you and best regards,
More information about the core-libs-dev