RFR 8184961: jdk.test.lib.util.FileUtils.deleteFileWithRetry0 should wait for absence of a file
hohensee at amazon.com
Wed Jul 26 17:03:54 UTC 2017
A double negative (!Files.notExists) somewhat unusual coding and will perplex people reading it. They might even switch it back to Files.exists as a style cleanup, so I recommend adding a comment explaining why you’re using it.
On 7/25/17, 5:08 PM, "core-libs-dev on behalf of Andrey Nazarov" <core-libs-dev-bounces at openjdk.java.net on behalf of andrey.x.nazarov at oracle.com> wrote:
> On 25 Jul 2017, at 16:41, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> Hi Andrei,
> I think this looks good.
> On Jul 25, 2017, at 3:59 PM, Andrey Nazarov <andrey.x.nazarov at oracle.com> wrote:
>> Can anyone look?
>>> On 19 Jul 2017, at 18:21, Andrey Nazarov <andrey.x.nazarov at oracle.com> wrote:
>>> Could you review fix in test library which should help to resolve intermittent issues on Windows machines during directories clean up.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8184961 <https://bugs.openjdk.java.net/browse/JDK-8184961>
>>> Review: http://cr.openjdk.java.net/~anazarov/JDK-8184961/webrev.00/webrev/
More information about the core-libs-dev