JDK10: RFR(xxs): 8181207: 8177809 breaks AIX 5.3, 6.1 builds
vyom.tewari at oracle.com
Thu Jun 1 04:15:08 UTC 2017
one minor comment apart from what Christoph gave, you can combine the
the two explicit assignment statements to one in all three places.
rv = (jlong)sb.st_mtimespec.tv_sec * 1000;
rv += (jlong)sb.st_mtimespec.tv_nsec / 1000000; to rv=
(jlong)sb.st_mtimespec.tv_sec * 1000 +(jlong)sb.st_mtimespec.tv_nsec / 1000000;
On Wednesday 31 May 2017 08:59 PM, Thomas Stüfe wrote:
> Hi Volker,
> Good suggestions! I completely overlooked the ..._n members in stat64
> struct. It seems it is even documented:
> new webrev:
> On Wed, May 31, 2017 at 10:49 AM, Volker Simonis <volker.simonis at gmail.com>
>> Hi Thomas,
>> as far as I can see, AIX supports both, the st_[a,c,m]time members in
>> the stat64 structure for seconds and the corresponding
>> st_[a,c,m]time_n members for nanosecond resolution since at least 5.3.
>> Can you please use both - there's no reason to discriminate AIX here
>> Also, can you please change the code such that we have:
>> #ifdef MACOSX
>> #ifdef AIX
>> I don't really like using "ifndef XXX" for everything else except XXX.
>> Thnank you and best regards,
>> On Tue, May 30, 2017 at 11:46 AM, Thomas Stüfe <thomas.stuefe at gmail.com>
>>> Hi all,
>>> may I have please a review for this tiny change:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8181207
>>> This reverts 8177809 for AIX because it leads to build errors on older
>>> systems. We want to retain the ability to build on older AIX releases.
>>> Thanks, Thomas
More information about the core-libs-dev