JDK 10 RFR of JDK-8181396: Refactor shell test java/nio/file/Files/delete_on_close.sh to java
amy.lu at oracle.com
Mon Jun 5 18:03:24 UTC 2017
On 6/6/17 12:11 AM, Amy Lu wrote:
> Good point!
> Please review the updated version:
Sorry, I have to withdraw this version. Somehow this does not work on
Windows, the created blah*tmp will not be deleted until the launched
DeleteOnClose (by itself) also exit.
(webrev.00 works fine.)
> On 6/5/17 10:52 PM, Alan Bateman wrote:
>> On 05/06/2017 07:54, Amy Lu wrote:
>>> Please review this patch to refactor the shell test to java.
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8181396
>>> webrev: http://cr.openjdk.java.net/~amlu/8181396/webrev.00/
>> I think it's a bit confusing to have both DeleteOnClose and
>> DeleteOnTerminate, esp. when DeleteOnTerminate creates a file with
>> DELETE_ON_CLOSE. Instead couldn't DeleteOnClose just launch itself to
>> create the file?
More information about the core-libs-dev