8179527:(8182743?) Ineffective use of volatile hurts performance of Charset.atBugLevel()
sean.coffey at oracle.com
Fri Jun 30 14:57:25 UTC 2017
minor comments from me.
* The bug ID referenced in mail/webrev links is wrong. It should be
* The copyright change in Charset-X-Coder.java.template is the wrong
format. You can simply replace 2013 with 2017.
On 29/06/17 19:49, Kazunori Ogata wrote:
> Hi Christoph,
> I updated webrev: http://cr.openjdk.java.net/~horii/8179527/webrev.02/
> This one includes changes in tests. I removed all @run and @build
> directives in the tests because those after removing "@run main/othervm
> -Dsun.nio.cs.bugLevel=1.4 EmptyCharsetName" are the same as the default
> ones. I checked the modified tests passed.
> I also fixed the copyright lines.
> "Langer, Christoph" <christoph.langer at sap.com> wrote on 2017/06/28
>> From: "Langer, Christoph" <christoph.langer at sap.com>
>> To: Kazunori Ogata <OGATAK at jp.ibm.com>
>> Cc: Alan Bateman <Alan.Bateman at oracle.com>, Claes Redestad
>> <claes.redestad at oracle.com>, core-libs-dev <core-libs-
>> dev at openjdk.java.net>, "nio-dev at openjdk.java.net" <nio-
>> dev at openjdk.java.net>, "ppc-aix-port-dev at openjdk.java.net"
>> dev at openjdk.java.net>
>> Date: 2017/06/28 21:04
>> Subject: RE: 8179527: Ineffective use of volatile hurts performance of
>> Hi Ogata,
>>>> remove the second run with -Dsun.nio.cs.bugLevel=1.4
>>> How can I do this? Is it sufficient to remove the following line at
>>> beginning of the file?: "@run main/othervm -Dsun.nio.cs.bugLevel=1.4
>> Yes, this line should be removed. Currently there are two @run
>> which cause running the testcase twice. Once in normal mode and once
>> bugLevel set to 1.4. So, if "sun.nio.cs.bugLevel" ought to be removed
>> the second iteration of the test is obsolete. And then one should
>> remove the whole "compat" handling in the test.
>> Best regards
More information about the core-libs-dev