RFR: 8174736: [JCP] [Mac]Cannot launch JCP on Mac os with language set to "Chinese, Simplified" while region is not China
naoto.sato at oracle.com
Mon Mar 6 23:33:39 UTC 2017
Hi Brent, thanks for the review!
On 3/6/17 3:21 PM, Brent Christian wrote:
> Hi, Naoto
> That fix looks fine.
> The "Portuguese (Brazil)" fix now happens before the Language ID fix,
> but that shouldn't matter, as the "pt_BR" ID won't trigger that code
> anyway (doesn't contain '-').
> One very mall nit I noticed: one more space on line 97 will realign it
> with line 96, which now has an additional '!' character.
Ah, good eye! Will fix it before the push.
> That's my small-'r'-review.
> On 03/03/17 13:19, Naoto Sato wrote:
>> Please review the fix to the following issue:
>> The proposed fix is located at:
>> This is a follow-on fix to 8174779 . The previous fix addresses the
>> issue for the default locale, and this one is to address the default
>> format locale in order to handle locales with script codes on macOS.
>>  https://bugs.openjdk.java.net/browse/JDK-8174779
More information about the core-libs-dev