RFR of JDK-8176721: @since value errors java.sql module

Lance Andersen lance.andersen at oracle.com
Tue Mar 14 11:05:50 UTC 2017

Hi Hamlin,

The changes for  xxxDataSource for the getXXX/setXXX methods which you marked as @since 9 is not correct. The common methods were placed in CommonDataSource in JDBC 4/JDK 1.6 to make it easier for updates.  Please see https://bugs.openjdk.java.net/browse/JDK-8164061 <https://bugs.openjdk.java.net/browse/JDK-8164061> which Joe Darcy had me make the changes that it references. I think your tool needs to somehow take this into account.

I think the rest of the changes look good but one to make another pass after some coffee :-)

B est

> On Mar 14, 2017, at 2:40 AM, Hamlin Li <huaming.li at oracle.com> wrote:
> Would you please review the below patch?
> bug: https://bugs.openjdk.java.net/browse/JDK-8176721
> webrev: http://cr.openjdk.java.net/~mli/8176721/webrev.00/
> Thank you
> -Hamlin

 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>

More information about the core-libs-dev mailing list