8184777: Factor out species generation logic from BoundMethodHandle

Claes Redestad claes.redestad at oracle.com
Tue Nov 14 17:35:30 UTC 2017

Hi Christoph,

On 2017-11-14 15:29, Christoph Dreis wrote:
> I still think it should be called "one integral bound value" instead of "values" and "has" instead of "have" (at least in case a singular species is meant).
> You seem to have fixed the singular "reference" typo only in ClassSpecializer.java.

I read your comment too fast. Fixed!

> While looking at ClassSpecializer again, I found two additional editorial things I wanted to raise:
> 1.)
> 364          * @return class name, which by default is {@code outer().topClass().getName() + "$Species_" + deriveTypeString(key)}
>   365          */
>   366         protected String deriveClassName() {
>   367             return topClass.getName() + "$Species_" + deriveTypeString();
>   368         }
> The @return doesn't seem to match the implementation. This looks a bit weird at least.

Updated code to match documentation.

> 2.)
> 328          * and produces a value of the required type.
> Should be "produce a value" given that "supply" is used some lines above.


> Again - I hope you don't mind these minor comments.

Don't mind at all. Some of the typos here were pre-existing, and while 
this is
internal code, it surely doesn't hurt cleaning up comments.




More information about the core-libs-dev mailing list