8189102: All tools should support -?, -h and --help

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Nov 22 17:28:09 UTC 2017


I prepared a new webrev trying to incorporate all change requests:
 * I removed changes to non-english property files.
 * I removed help texts from ktab, kinit, klist
 * I removed changes to corba tools
 * I added test cases for new flags to tool specific tests (to the ones I spotted)
 * I added -help back to javac
I left the removal of -help from Javadoc, as Javadoc just prints the help message

New webrev:

I uploaded the parts of the patch I removed within the webrev:

Best regards,

> -----Original Message-----
> From: serviceability-dev [mailto:serviceability-dev-
> bounces at openjdk.java.net] On Behalf Of Lindenmaier, Goetz
> Sent: Friday, November 17, 2017 12:23 PM
> To: core-libs-dev at openjdk.java.net; 'compiler-dev at openjdk.java.net'
> <compiler-dev at openjdk.java.net>; serviceability-dev (serviceability-
> dev at openjdk.java.net) <serviceability-dev at openjdk.java.net>
> Subject: RFR: 8189102: All tools should support -?, -h and --help
> Hi,
> please review this change. I also filed a CSR for this:
> http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.02/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189102
> CSR: https://bugs.openjdk.java.net/browse/JDK-8191477
> See the webrev for a detailed description of the changes.
> If required, I'll make break-out changes to be reviewed separately.
> I had posted a RFR before, but improved the change to
> give a more complete overview of currently supported flags
> for the CSR:
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-
> October/028615.html
> Best regards,
>   Goetz.

More information about the core-libs-dev mailing list