(S) RFR 8191788: add jdk.internal.vm.compiler to --limit-modules if -Djvmci.Compiler=graal is in the command line
calvin.cheung at oracle.com
Wed Nov 29 06:15:39 UTC 2017
Fix looks good to me.
Could you break up lines #3386 (104 chars) and #3391 (146 chars)?
No need to send another webrev for the above change.
On 11/28/17, 3:51 PM, Vladimir Kozlov wrote:
> This is redo of JDK-8190975  fix which added
> jdk.internal.vm.compiler to tests which have --limit-modules option.
> Unfortunately tests start failing on SPARC where Graal
> (jdk.internal.vm.compiler) is not available. JDK-8191653  reversed
> 8190975 changes to fix that problem.
> This fix adds jdk.internal.vm.compiler to --limit-modules list in JVM
> only when Graal is used: when it is explicitly specified with
> -Djvmci.Compiler=graal or in default case and when UseJVMCICompiler is
> I tested the fix with failed tests from JDK-8190975 which are mostly
> AppCDS tests in test/runtime/appcds/jigsaw and also
> I think this fix may break upgradeable status of Graal (for Oracle
> Labs version of Graal).
> But it should be fine since it is only used with --limit-modules which
> is not used by Labs.
>  http://hg.openjdk.java.net/jdk/hs/rev/8deb7919d118
>  http://hg.openjdk.java.net/jdk/hs/rev/b38d8aadcada
More information about the core-libs-dev