RFR (JDK10/JAXP) 8181150: Fix lint warnings in JAXP repo: rawtypes and unchecked

Joe Wang huizhe.wang at oracle.com
Wed Oct 18 20:15:41 UTC 2017

Thanks Roger!

We'll go through a bunch of much smaller patches once this one is out of 
the way. After BCEL update and this, we'll go from over 5000 warnings 
down to 365 that will be fixed in three separate categories.


On 10/18/17, 10:57 AM, Roger Riggs wrote:
> Hi Joe,
> The changes look fine.
> Maybe do them in smaller batches next time with a consistent kind of 
> change. Just thought.
> Thanks, Roger
> On 10/12/17 11:24 AM, Joe Wang wrote:
>> Hi,
>> Please review a cleanup of rawtypes and unchecked warnings from JAXP 
>> sources.
>> The patch involved a good number of classes (278). However, the 
>> majority of the changes are straight-forward replacement, e.g. 
>> s/Vector/List[ArrayList] and their relevant methods e.g. 
>> s/elementAt/get and etc. In a few cases, 
>> ArrayIndexOutOfBoundsException was substituted with 
>> IndexOutOfBoundsException as they were caught.
>> A few cleanups unrelated to rawtypes and unchecked were made before 
>> Roger's suggestion to stay within the scope of the request, that is, 
>> a couple of StringBuffer substitution, other than that this changeset 
>> is almost rawtypes and unchecked cleanup only.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8181150
>> webrevs: http://cr.openjdk.java.net/~joehw/jdk10/8181150/webrev/
>> Thanks,
>> Joe

More information about the core-libs-dev mailing list