Review Request JDK-8187089: StringConcatFactory.makeConcat & makeConcatWithConstants should throw StringConcatException if parameter slot count is over 200

Aleksey Shipilev shade at
Thu Oct 19 08:55:56 UTC 2017

On 10/19/2017 01:32 AM, mandy chung wrote:
> StringConcatFactory::makeConcat and makeConcatWithConstants APIs are
> specified to accept concatType to have a maximum of 200 parameter slots.
> If violated, it should throw StringConcatException.  The implementation
> mistakenly checks the parameter count.  The javadoc of these methods
> states "parameter count" rather than "parameter slots" whereas
> @apiNote in the class spec correctly says "parameter slots".
> Webrev:

Looks good, thanks for taking care of this!


More information about the core-libs-dev mailing list