RFR (JDK10/JAXP) 8181155: Fix lint warnings in JAXP repo: fallthrough and static
Roger.Riggs at Oracle.com
Mon Oct 30 18:14:01 UTC 2017
Is there a useful comment on the @SuppressWarnings like in other files:
A few of the added breaks would have been hiding bugs.
It might be worth mentioning them in the issue.
On 10/30/2017 1:09 PM, Lance Andersen wrote:
> Hi Joe
> The changes look OK
>> On Oct 30, 2017, at 1:03 PM, Joe Wang <huizhe.wang at oracle.com> wrote:
>> Please review a cleanup of fallthrough and static warnings. For fallthrough, the majority of the changes are suppressing the warnings, while for static, replacing the instances with the class.
>> All jaxp tests and JCK passed.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8181155
>> webrevs: http://cr.openjdk.java.net/~joehw/jdk10/8181155/webrev/index.html
> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
More information about the core-libs-dev