RFR 8187631 : Refactor FileDescriptor close implementation

Alan Bateman Alan.Bateman at oracle.com
Tue Sep 19 12:48:12 UTC 2017

On 18/09/2017 20:28, Roger Riggs wrote:
> In anticipation of the re-opening (not yet) of the JDK 10 repo please 
> review refactoring
> the handling of closing of files in FileInputStream, FileOutputStream, 
> RandomAccessFile,
> and FileChannelImpl and related native code.
> The refactoring enables a future improvement to use the cleaner to 
> close raw fds
> when the FileDescriptors becomes unreferenced.
> Webrev:
>    cr.openjdk.java.net/~rriggs/webrev-fd-refactor-8187631/
> Issue:
>   https://bugs.openjdk.java.net/browse/JDK-8187631
This looks okay to me.

One thing to clear up in JavaIOFileDescriptorAccess is the parameter 
names as it seems to use "obj" in some places, "fd" in others.


More information about the core-libs-dev mailing list