RFR 8187631 : Refactor FileDescriptor close implementation

Brian Burkhalter brian.burkhalter at oracle.com
Tue Sep 19 14:52:09 UTC 2017

Hi Roger,

On Sep 19, 2017, at 6:51 AM, Roger Riggs <Roger.Riggs at oracle.com> wrote:

> The updated webrev is:
> http://cr.openjdk.java.net/~rriggs/webrev-fd-refactor-8187631-02/
> I avoided cluttering the initial webrev with misc cleanup.

This looks good. The name “rawfd” is good. It could equally well be named “nativefd” but that’s being picky.

> I renamed the parameters, corrected some old <code></code> markup and reordered
> the declarations so a side-by side diff of the Unix and Windows FileDescriptor.java files
> makes it easy to see the necessary differences.

All good.

> (Perhaps a future cleanup can merge the two and manage all the other differences in the native code.)

This would be nice to accomplish.



More information about the core-libs-dev mailing list