RFR 8080225: FileInputStream cleanup should be improved

Brian Burkhalter brian.burkhalter at oracle.com
Fri Sep 29 20:02:41 UTC 2017

Hi Roger,

Looks good overall; total nitpicks here:

FileInputStream (similar story in FileOutputStream)
48-49: “explicitly" is used twice
53: could probably drop “explicitly” here altogether.

The “Shd” in a couple of test names is kind of annoying; perhaps s/Shd/Should/ ?

Copyright dates are not update in a few places.



On Sep 29, 2017, at 10:17 AM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:

> Comments are appreciated on […] the implementation [1].
> [1] webrev: http://cr.openjdk.java.net/~rriggs/webrev-fis-cleanup-8080225/

More information about the core-libs-dev mailing list