RFR: 8164781: Pattern.asPredicate specification is incomplete

Vivek Theeyarath vivek.theeyarath at oracle.com
Thu Apr 5 10:34:33 UTC 2018

>> Hi,
>> 	I have incorporated the changes as per the feedback and here is the updated webrev .
>> http://cr.openjdk.java.net/~rraghavan/8164781/webrev.02/ .
>>Bug: https://bugs.openjdk.java.net/browse/JDK-8164781 

Thanks Paul

>I know it’s picky, but would you mind sticking closer to the existing line length in the source file
>(no need for another review)
Here is my attempt. Hope it is better now. http://cr.openjdk.java.net/~rraghavan/8164781/webrev.03 

>Did you run the jtreg test to verify it passes? I missed the problem initially, glad Stuart caught it, but i presume the test would of reported a failure? if not there is something wrong with the test itself that should be investigated.

I missed it earlier. As you rightly pointed out, without Stuart's inputs the test fails and it passes with it as expected.

>> Here is the related csr https://bugs.openjdk.java.net/browse/JDK-8200603 

>Ok, i tweaked some of the information (after creating a CSR one often needs to edit it to fill in the gaps).

>Can you blockquote the markdown for the embedded patch since the formatting is all messed up?

I have restored the formatting. Hope it would suffice.


More information about the core-libs-dev mailing list