RFR: Here are some easy patches

Martin Buchholz martinrb at google.com
Mon Apr 30 18:18:18 UTC 2018

On Mon, Apr 30, 2018 at 10:35 AM, Paul Sandoz <paul.sandoz at oracle.com>

> An obvious optimization:
> 8202398: Optimize Arrays.deepHashCode
> http://cr.openjdk.java.net/~martin/webrevs/jdk/deepHashCode-optimize/
> https://bugs.openjdk.java.net/browse/JDK-8202398
> I would prefer that the deeply nested ternary expressions be changed to a
> more expected if/else if/else

My brain much prefers code transforming tabular data to "look tabular".

> , and the last else throws an InternalError(“Should not reach here”) with
> some such message if you really want to express the case of an undetected
> array type.

I'd hope valhalla engineers will catch it before anyone else.  In fact,
perhaps it's not too early to add a test as part of the valhalla project

More information about the core-libs-dev mailing list