8202794: Native Unix code should use readdir rather than readdir_r

B. Blaser bsrbnd at gmail.com
Tue Jul 17 16:05:03 UTC 2018

On 17 July 2018 at 09:46, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 17/07/2018 04:57, Brian Burkhalter wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8202794
>> Continues thread [1] with subject line updated to match the issue summary.
>> Part of this general problem was addressed in [2].
>> The patch is in effect that proposed in thread [1] less the changes in
>> [2]:
>> http://cr.openjdk.java.net/~bpb/8202794/webrev.00/
>> Thanks to Bernard Blaser for the patch.
>> There were no build errors on Linux, macOS, nor Solaris, nor in the usual
>> set of regression tests on these platforms.
> For serviceability-dev but I assume OperatingSystemImpl.c should move to
> readdir64 to be consistent with the other usages.
> Separately, we have few inconsistencies (including in TimeZone_md.c and
> UnixFileSystem_md.c) where opendir/closedir is used instead of
> opendir64/closedir64. Looks like the AIX port may have run into issues as it
> redefines them. Something for a separate issue of course.
> -Alan

Looks good to me too.
I've also noted the small inconsistencies between readdir64 and
opendir/closedir to be addressed in a separate issue.


More information about the core-libs-dev mailing list