RFR (JDK11) 8183554: Add constructors with Charset parameter for FileReader and FileWriter

Alan Bateman Alan.Bateman at oracle.com
Mon Mar 5 20:41:55 UTC 2018

On 05/03/2018 19:25, Joe Wang wrote:
> Hi,
> Adding constructors with a Charset parameter for FileReader and 
> FileWriter. Please review.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8183554
> webrev: http://cr.openjdk.java.net/~joehw/jdk11/8183554/webrev/
The constructors that take String+Charset and File+Charset looks fine. 
I'm less sure about the constructors that take FileDescriptor+Charset, 
mostly because FileDescriptor is always problematic and I wouldn't 
expect most developers to every need this. Would you be open to leaving 
those out of the proposal?


More information about the core-libs-dev mailing list