RFR(XS) [closed] : 8198924: java/lang/StackWalker/LocalsAndOperands.java timeouts with Graal
ekaterina.pavlova at oracle.com
Wed Mar 7 18:05:01 UTC 2018
Mandy, Brent, thanks for reviews.
Removing @bug will not allow to find this testcase by bugid (jtreg -bug:<bugid>).
So, I think it is safe to omit only @summary.
On 3/6/18 2:30 PM, Brent Christian wrote:
> Looks good, Katya - thanks.
> I agree with omitting @bug and @summary from the second @test tag.
> On 3/6/18 1:59 PM, mandy chung wrote:
>> Running #1 and #2 when Graal is enabled is fine.
>> For the second @test, does it need @bug and @summary to run? If not, I suggest to take it out as it's already mentioned in the first @test.
>> On 3/6/18 1:45 PM, Ekaterina Pavlova wrote:
>>> Hi all,
>>> java/lang/StackWalker/LocalsAndOperands.java runs LocalsAndOperands 3 times with following set of jvm flags:
>>> 1) -Xint -DtestUnused=true
>>> 2) -Xcomp
>>> 3) -Xcomp -XX:-TieredCompilation
>>> When running with Graal as JIT (-XX:+TieredCompilation -XX:+UseJVMCICompiler -Djvmci.Compiler=graal)
>>> 3rd scenario could take more than 10 minutes and the test could fail by timeout.
>>> Actually running LocalsAndOperands with Graal and with "-Xcomp -XX:-TieredCompilation" doesn't provide
>>> big benefit and it would be reasonable to disable this scenario in case Graal is enabled.
>>> Please review the change.
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8198924
>>> webrev: http://cr.openjdk.java.net/~epavlova//8198924/webrev.00/index.html
>>> testing: Tested by running the test in Graal as JIT mode.
>>> Igor Ignatyev volunteered to sponsor this change.
More information about the core-libs-dev