RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Thu Mar 22 14:18:24 UTC 2018


Why would the VM emit these warnings if the deprecated vm flag
is not being used ?

As for the reviews I am ok with InfoStreams, wrt. ToolOpts it is not at 
all apparent,
maybe more comments explaining what is going on ?


> Hi Andrei,
> On 22/03/2018 11:12 AM, Andrey Nazarov wrote:
>> Hi,
>> Please review fix in launcher tests.
>> Review: http://cr.openjdk.java.net/~anazarov/JDK-8196750/webrev/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8196750?filter=-1
> test/jdk/tools/launcher/ToolsOpts.java
> I don't understand how the change fixes the problem. IIUC the problem 
> is that the test expects the output to consist of the command-line 
> passed to the tool. Instead if it contains a Warning from the VM, it 
> won't match and so we fail. The new code no longer uses a String[] and 
> no longer assumes that output[i] == args[i], but it still searches the 
> current "output" value for a match with one of the args. But that will 
> still fail if what we actually have is a Warning. ?? I would have 
> expected to see the Warning strings filtered out more directly.
> The other test change seems reasonable.
> Thanks,
> David
>> —Thanks,
>>   Andrei

More information about the core-libs-dev mailing list