[JDK-6341887] RFR: Patch V3: java.util.zip: Add ByteBuffer methods to Inflater/Deflater
david.lloyd at redhat.com
Thu Mar 29 12:18:30 UTC 2018
On Wed, Mar 28, 2018 at 11:38 PM, Xueming Shen <xueming.shen at oracle.com> wrote:
> On 3/28/18, 6:14 AM, David Lloyd wrote:
>> I've implemented all the other changes except for this one. Latest
>> version is attached, online version is here .
> "flush marker" was copy/pasted from the original zlib.h api doc when I added the
> support for different flush options. It might be better to put it is a apiNote. A
> "flush marker" in this case is a 5-byte empty block, which will be output if the
> deflater does not have enough space to output the bytes and it is in full_flush or
> sync_flush mode. I think you can leave it as is for now and I will try to see if I
> can move it around or add some understandable wording, if I can.
OK great. In that case, I think all feedback has been accounted for,
and this should be ready to go AFAIK.
More information about the core-libs-dev