[JDK-6341887] RFR: Patch V3: java.util.zip: Add ByteBuffer methods to Inflater/Deflater
david.lloyd at redhat.com
Fri Mar 30 17:23:32 UTC 2018
On Fri, Mar 30, 2018 at 12:05 PM, Xueming Shen <xueming.shen at oracle.com> wrote:
> Hi David,
> (1) Deflater.setDictionary(ByteBuffer) missed a "@since 11"
Oops, easy fix.
> (2) infalte(...) may not need to catch DFE twice, better (?) to just update
> the inputPos/input
> at outsider catch as
> if (input == null)
> this.inputPos = inputPos + inputConsumed;
> input.position(inputPos + inputConsumed;
> the if/else might be repetitive, but better than two layers of same DFE
I'm okay with anything at this point, but this does introduce a
"inputPos possibly not initialized" problem which doesn't seem to have
a clean solution. WDYT?
More information about the core-libs-dev