RFR: 8221477: Inject os/cpu-specific constants into Unsafe from JVM
adinn at redhat.com
Fri Apr 5 08:49:50 UTC 2019
On 05/04/2019 04:54, David Holmes wrote:
> Hi Andrew,
> This all looks good to me - thanks for making the changes.
Thank you for the corrections and improvements.
> Two nits:
> - BE was barely acceptable when used like a local variable, but now I
> think BIG_ENDIAN would be better.
> - If you don't use static import you can name the UnsafeConstants fields
> the obvious way without clashing with public fields in Unsafe.
> Feel free to ignore those nits. If you do make a change no need to see
> another webrev.
Well, I changed BE to BIG_ENDIAN and it doesn't look as messy as I
thought. So BIG_ENDIAN it is.
However, omitting the static import requires UnsafeConstants.BIG_ENDIAN
at multiple mentions. That does look too cluttered for comfortable reading.
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
More information about the core-libs-dev