RFR: 8221397 Support implementation-defined Map Modes

Andrew Dinn adinn at redhat.com
Mon Apr 8 14:05:29 UTC 2019

On 08/04/2019 14:59, Alan Bateman wrote:
> On 08/04/2019 10:52, Andrew Dinn wrote:
>> :
>> I created the following CSR
>>    https://bugs.openjdk.java.net/browse/JDK-8222107
>> Apologies if I got anything wrong (first time I have done this :-).
>> Do I need to solicit reviews or does this automatically get dispatched
>> to the relevant component/sub-component leads?
> Once you have a Reviewer then you can finalize it.

Ok, reviews for the above CSR are officially requested ...

> One thing that we haven't discussed is equality. If someone invokes
> FileChannel.map with a map mode created with new MapMode("READ_WRITE")
> then it will throw UOE as it's not (reference) equal to
> MapMode.READ_WRITE. It's implied by the javadoc "One of the constants
> ..." but now that it is extensible then we may need a statement in the
> javadoc - do you want me to suggest something?
Hmm, yes that's an interesting point. Of course, I'll take whatever
suggestions you are willing to throw this way :-)


Andrew Dinn
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

More information about the core-libs-dev mailing list