RFR : 8221696: MappedByteBuffer.force method to specify range

Andrew Dinn adinn at redhat.com
Wed Apr 10 11:15:19 UTC 2019

On 09/04/2019 18:59, Alan Bateman wrote:
> There are a couple of implementation details to discuss but I'll stick
> to the API/javadoc for now so that you can create the CSR.

Ok, thanks.

> We discussed the method signature, parameter types, and the semantics in
> previous mails so I think they are all okay (meaning the first parameter
> is the index in the buffer of the first byte to write back and not an
> offset from the position). One nit is that the existing absolute methods
> name the parameter "index" and I think we should do the same here.

Yes, that is clearer as well as consistent.

> In the first sentence it might be better to say "a region" rather "some
> region". You could expand this paragraph with a second sentence,
> something like "The region starts at the given {@code index} in this
> buffer and is {@code length} bytes".


> A suggestion for the description for the index and length parameters is
> copy the wording/style from the existing absolute methods, e.g.
> @param index The index of the first byte of the regsion; must be
> non-negative and less than limit()
> @param length The length of the region in bytes; must be non-negative
> and no larger than limit() - index
> @throws IndexOutOfBoundException If the preconditions on the index and
> length do not hold.


An updated webrev is available:

JIRA:   https://bugs.openjdk.java.net/browse/JDK-8221696
webrev: http://cr.openjdk.java.net/~adinn/8221696/webrev.01

I will also create a CSR based on the changes in this webrev and post an


Andrew Dinn
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

More information about the core-libs-dev mailing list