RFR(s): 8217405 rmic should reject class files with preview features enabled

Alan Bateman Alan.Bateman at oracle.com
Thu Apr 11 12:36:14 UTC 2019

On 11/04/2019 02:22, Stuart Marks wrote:
> Hi all,
> Please review this small fix to rmic to make it reject class files 
> that were compiled with preview features enabled.
> Bug:
>     https://bugs.openjdk.java.net/browse/JDK-8217405
> Webrev:
>     http://cr.openjdk.java.net/~smarks/reviews/8217405/webrev.0/
> Note that there is no regression test with this patch; I've added the 
> noreg-hard label. The main reason is that to test this properly 
> requires multiple different JDK versions to be available 
> simultaneously, which isn't supported in out the test environment. One 
> could work around this, e.g. by constructing class files with the 
> desired version information, from but this hardly seems worth it for 
> something like rmic.
I think this looks okay. If you are putting any effort into rmic then I 
think it should be to work out a plan to remove it :-)


More information about the core-libs-dev mailing list