RFR: JDK-8212780: JEP 343: Packaging Tool Implementation
erik.joelsson at oracle.com
Mon Apr 29 16:21:54 UTC 2019
We did review build changes as they were done in the sandbox, but IMO
this change needs a fresh review now since some things have changed in
the build since those reviews took place.
The -parameters flag to javac is currently only used for jdk.aot and
jdk.internal.vm.ci, where a comment is explaining why its needed in
those particular cases. Why is it needed for jdk.jpackage? We would like
to avoid snowflakes if possible.
There is a new set of macros that should be used to check things like
target OS. The new macro is called like this:
ifeq ($(call isTargetOs, windows macosx linux), false)
Lib-jdk.jpackage.gmk and Launcher-jdk.jpackage.gmk:
Same thing with checking for target OS:
ifeq ($(call isTargetOs, windows), true)
Otherwise this looks good from a build perspective.
On 2019-04-27 17:46, Philip Race wrote:
> Adding build-dev for the build changes. I don't know if these were
> previously reviewed there,
> but I am not sure what the changes in NativeCompilation.gmk have to do
> with jpackage.
> On 4/24/19, 5:47 PM, Andy Herrick wrote:
>> On 4/24/2019 8:44 PM, Andy Herrick wrote:
>>> Please review changes for  which is the implementation bug for
>>> The webrev at  is the total cumulative webrev of changes for the
>>> jpackage tool, currently in the JDK-8200758-branch branch of the
>>> open sandbox repository.
>>> The webrev at  shows the changes from EA-05 to EA-06.
>> sorry - the links are reversed from what is stated above.  is the
>> incremental webrev since EA 05,  is the cumulativewebrev
>>> The latest EA-6 (build 49) is posted at .
>>> Please send feedback to core-libs-dev at openjdk.java.net
>>>  https://bugs.openjdk.java.net/browse/JDK-8200758
>>>  http://cr.openjdk.java.net/~herrick/8212780/webrev.05-06/
>>>  http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/
>>>  http://jdk.java.net/jpackage/
More information about the core-libs-dev