RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Phil Race philip.race at oracle.com
Tue Apr 30 22:53:01 UTC 2019

A couple of questions / observations :-

1) setlocale

   52 int main(int argc, char *argv[]) {
   53     int result = 1;
   54     setlocale(LC_ALL, "en_US.utf8");

Why is this setlocale() call there ?

What does this mean for a user whose desktop is (say) German, or French, or Japanese ?

When the Java app is launched from this environment is it inheriting this US locale ? I hope not.

We have the same on Mac :-


and windows :-


   64     ::setlocale(LC_ALL, "en_US.utf8");

2) C++ files containing C




have their entire contents wrapped in

   36 #ifdef __cplusplus
   37 extern "C" {
   38 #endif

  159 #ifdef __cplusplus
  160 }
  161 #endif

wouldn't it be better to put them in .c files ?


More information about the core-libs-dev mailing list