RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Kevin Rushforth kevin.rushforth at oracle.com
Tue Apr 30 23:02:09 UTC 2019

I have a couple nit-picky comments:

1. The change to src/jdk.jlink/share/classes/module-info.java is 
unrelated to jpackage and should be reverted (there is only a 
white-space change and a copyright date change to that file)

2. The following files have whitespace errors that will cause jcheck to 
Trailing whitespace
Tab character
Trailing whitespace
Trailing whitespace

3. I recommend to replace the wild-card imports with explicit imports, 
for example:
(java.util.* and java.io.*)
(I think the wild-card static import is fine, just not the import every 
class from a package)

I'll try to remember to note these as I go through the review. This one 
could be done as a follow-up bug rather than doing it prior to 
integration if you prefer.

-- Kevin

More information about the core-libs-dev mailing list