RFR(JDK 13/java.xml) 8187697: Cleanup: irrelevant code in OutputPropertiesFactory
huizhe.wang at oracle.com
Wed Feb 13 20:35:57 UTC 2019
On 2/13/19, 11:55 AM, Lance Andersen wrote:
> Hi Joe
> Overall the change seems Ok, assuming all the tests are happy :-)
Yes, they all are happy.
> One minor suggestion for:
> - line 150, please put the ‘*/“ on its own line
>> On Feb 13, 2019, at 1:15 PM, Joe Wang <huizhe.wang at oracle.com
>> <mailto:huizhe.wang at oracle.com>> wrote:
>> Please review a cleanup patch for the OutputPropertiesFactory.
>> The original intention was to remove the (awkward) JDK 1.2-related
>> code, line 235-258 in the old file. I then went a bit further to
>> remove another nuisance that annoyed users with an error "Could not
>> load the property file 'output_xml.properties' for output method
>> 'xml'" from time to time. The output properties files are now removed
>> and the contents moved into static arrays in OutputPropertiesFactory
>> between line 192 and 288 in the new file.
>> The processing process is kept mostly as is. The only change was
>> removing the "fixupPropertyString" process, as a result the only line
>> kept from the old file line 447 - 500 was line 376 in the new file.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187697
>> webrevs: http://cr.openjdk.java.net/~joehw/jdk13/8187697/webrev/
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
More information about the core-libs-dev