RFR (M): JDK-6394757: AbstractSet.removeAll semantics are surprisingly dependent on relative sizes

Stuart Marks stuart.marks at oracle.com
Wed May 8 20:42:01 UTC 2019

On 5/7/19 8:21 AM, Pavel Rappo wrote:
> That looks good.
> A tiny note on your FIXME comment [1]:
>    68     // FIXME: the first paragraph below is copied from Set.equals, because
>    69     // {@inheritDoc} will include text from Object.equals.
> You might want to check if it is the same as [2] or [3]. If it is the same,
> consider adding a reference to the appropriate issue to that FIXME comment for
> future maintainers. It looks like there are some problems when inheriting
> documentation from methods defined in java.lang.Object.

> [1] http://cr.openjdk.java.net/~smarks/reviews/6394757/webrev.0/src/java.base/share/classes/java/util/AbstractSet.java.sdiff.html
> [2] https://bugs.openjdk.java.net/browse/JDK-8144034
> [3] https://bugs.openjdk.java.net/browse/JDK-6376959

Thanks Pavel. I looked at this and it does seem related to javadoc bug 
JDK-6396959. I've added some notes to that bug report. I'll add a reference to 
this bug report in the changeset near FIXME.

There are a couple other places in the collections doc that have this same 
pathology (i.e., text is copied instead of @inheritDoc). I'll see if I can find 
them and note them with a FIXME as well.

Thanks also for your misc markup changes sent offline.


More information about the core-libs-dev mailing list