RFR: JDK-8223725: j.l.c.MethodHandleDesc::of throws undocumented exception IllegalArgumentException
vicente.romero at oracle.com
Mon May 20 17:07:21 UTC 2019
how does it look now?
On 5/17/19 3:58 PM, Vicente Romero wrote:
> Hi Roger,
> Thanks for the review, my apologies, I made a mistake an applied the
> change to the wrong method. I have corrected the patch  and the CSR
> . I have updated the language used as you suggested,
>  http://cr.openjdk.java.net/~vromero/8223725/webrev.01/
>  https://bugs.openjdk.java.net/browse/JDK-8223920
> On 5/17/19 2:05 PM, Roger Riggs wrote:
>> Hi Vicente,
>> What's the difference in the IAE exceptions describing IAE's as
>> being "incorrect formats' vs 'is invalid' or 'not valid'?
>> Each requires a spec for valid and invalid strings or is undefined.
>> Can the new IAE use the same language as is used for the ofDescriptor
>> Avoiding any question about differences.
>> 69: Also, is the word 'lookup' overloaded? Is 'lookup' is
>> significant in this context?
>> On 05/14/2019 06:37 PM, Vicente Romero wrote:
>>> Please review fix  for  and the corresponding CSR at . The
>>> fix is just adding a missing @throws at method
>>> j.l.c.MethodHandleDesc::of. It is a one liner fix,
>>>  http://cr.openjdk.java.net/~vromero/8223725/webrev.00/
>>>  https://bugs.openjdk.java.net/browse/JDK-8223725
>>>  https://bugs.openjdk.java.net/browse/JDK-8223920
More information about the core-libs-dev