RFR: 8223773: DateTimeFormatter Fails to throw an Exception on Invalid CLOCK_HOUR_OF_AMPM and HOUR_OF_AMPM
Roger.Riggs at oracle.com
Thu May 30 13:55:22 UTC 2019
This looks ok.
Typically, it is not necessary to check the exception message text.
On 05/29/2019 05:21 PM, Lance Andersen wrote:
> Hi Naoto,
> This is OK.
> Could you please add an @summary as it is missing so that we are consistent with other tests.
> No need to spin a webrev again though
>> On May 29, 2019, at 5:12 PM, naoto.sato at oracle.com wrote:
>> Please review the fix for the following issue:
>> The proposed changeset is located at:
>> Checking the range of HourOfAmPm with the range of AmPmOfDay is apparently incorrect. Fixing it will change the behavior of parsing with SMART resolver style to throw a DateTimeParseException. This is a change in which an app will start to see an exception with incorrect data, but that is what should be in the first place.
> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
More information about the core-libs-dev