RFR: 8234335: Remove line break in class declaration in java.base
Roger.Riggs at oracle.com
Wed Nov 20 17:31:47 UTC 2019
On 11/20/19 12:02 PM, Lance Andersen wrote:
> Looks Good Julia
>> On Nov 20, 2019, at 5:52 AM, Julia Boes <julia.boes at oracle.com> wrote:
>>>>> Seems to be a “your milage varies”. I am fine with whatever the
>>>>> final decision is. However, I do believe the comment above reads
>>>>> better and aligns the methods better.
>>>> FWIW, and as author of many of the lines being changed, I prefer that
>>>> comment on a separate from the actual modifiers. I think the basic
>>>> modifier patterns are easier to recognize quickly when comments and
>>>> annotations are separate.
>>> Personally I prefer to place such pseudo-modifiers on the same line
>>> as the actual modifiers, but I accept that some prefer otherwise.
>>> When in doubt, respect the original author’s choice.
>> Thanks for your comments. The separate-line version it is then!
>> Updated webrev:http://cr.openjdk.java.net/~jboes/webrevs/8234335/webrev.02/
> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
More information about the core-libs-dev