RFR: JDK-8230920 : jpackage problems when -input dir contains any files with "cfg" extension.

Alexander Matveev alexander.matveev at oracle.com
Tue Sep 24 23:29:30 UTC 2019

Hi Andy,

Looks good.

Do you think it would be better to write CLI arguments in some internal 
format instead of just raw dump? It might be better in case if we plan 
to change CLI between versions and at same time supporting generation of 
installers for app image using different jpackage versions.


On 9/24/2019 5:54 AM, Andy Herrick wrote:
> Please review the jpackage fix for bug [1] at [2].
> This is a fix for the JDK-8200758-branch branch of the open sandbox 
> repository (jpackage).
> This fix replaces the practice we were using on windows to determine 
> the application name, and name of additional launchers (by looking for 
> ".cfg" files in the app dir.
> Instead we now add a file ".jpackage.args" to the root of the 
> app-image, and record in that file all the arguments used to create 
> the app-image.  We later read that file to determine the original app 
> name and any additional launcher names.
> This change also fixes the shortcut creation on windows to create 
> shortcuts (if so directed) for all launchers.
> [1] https://bugs.openjdk.java.net/browse/JDK-8230920
> [2] http://cr.openjdk.java.net/~herrick/8230920/webrev.01/
> /Andy

More information about the core-libs-dev mailing list