RFR(S): 8240333: jmod incorrectly updates .jar and .jmod files during hashing
volker.simonis at gmail.com
Tue Mar 3 18:01:02 UTC 2020
On Tue, Mar 3, 2020 at 5:27 PM Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 03/03/2020 11:01, Volker Simonis wrote:
> > Hi,
> > can I please get a review for the following small fix:
> > http://cr.openjdk.java.net/~simonis/webrevs/2020/8240333/
> > https://bugs.openjdk.java.net/browse/JDK-8240333
> The code changes okay but I think the comment needs a bit of clean-up.
> Maybe drop L96-97 so that it just says that it preserves the attributes
> that don't change.
Thanks. Shortened the comments as suggested:
More information about the core-libs-dev