RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution
adam.farley at uk.ibm.com
Thu Mar 5 14:31:54 UTC 2020
As mentioned by Tom, a third opinion is sought on the aforementioned
minor test change.
@Tom - I'd prefer to use the full version of the error messages to keep
things clear, though I would not object to using your abbreviated version
if it means getting the change in.
So long as it passes when it should pass, and fails only when it should
fail, clarity is a "would be nice", but ultimately a secondary priority.
Thanks for your feedback. :)
"Thomas Stüfe" <thomas.stuefe at gmail.com> wrote on 03/03/2020 10:52:10:
> From: "Thomas Stüfe" <thomas.stuefe at gmail.com>
> To: Adam Farley8 <adam.farley at uk.ibm.com>
> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>
> Date: 03/03/2020 10:52
> Subject: [EXTERNAL] Re: RFR: 8239365: ProcessBuilder/Basic.java test
> modifications for AIX execution
> This is why I always was against handing up the result of strerror
> to the user :) The same problem we would have when running with
> different locales. We should have a platform agnostic string table
> in the java lib for that purpose...
> As for the test, looks good, but I personally would shorten the AIX
> patterns a bit or maybe try to find a short form fitting all
> platforms (e.g. "[Pp]ermission").
> But thats just idle bikeshedding, lets see what others think.
> Cheers Thomas
> On Tue, Mar 3, 2020 at 11:43 AM Adam Farley8 <adam.farley at uk.ibm.com>
> Hi All,
> Reviews and sponsor requested for a small test change.
> Short version: When an AIX machine has the file set "bos.msg.en_US.rte",
> the error messages are not in a form that the test expects, causing
> The simplest option appears to be adding the second potential form of
> message into the regex (see webrev).
> Bug: https://bugs.openjdk.java.net/browse/JDK-8239365
> Best Regards
> Adam Farley
> IBM Runtimes
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
More information about the core-libs-dev