RFR(S): 8240734: ModuleHashes attribute not reproducible between builds
mandy.chung at oracle.com
Wed Mar 11 17:40:18 UTC 2020
On 3/11/20 12:21 AM, Yangfei (Felix) wrote:
>> -----Original Message-----
>> From: Alan Bateman [mailto:Alan.Bateman at oracle.com]
>> Sent: Wednesday, March 11, 2020 3:03 PM
>> To: Yangfei (Felix) <felix.yang at huawei.com>; core-libs-dev at openjdk.java.net
>> Subject: Re: RFR(S): 8240734: ModuleHashes attribute not reproducible
>> between builds
>> On 11/03/2020 01:11, Yangfei (Felix) wrote:
>>> Thanks for reviewing this. Pushed.
>> Okay but I think we need to add a test for this. Can you look at
>> JLinkReproducibleTest and see if it can be extended to use
>> --keep-packaged-modules so that you have the JMOD files in the run-time
> Sure. We will take a look.
I created a JBS issue:
I was expecting this fix be pushed when you have added a regression
test. It's okay as it's pushed. Please add one to retrofit that.
More information about the core-libs-dev