RFR: 8264208: Console charset API [v2]

Naoto Sato naoto at openjdk.java.net
Fri Apr 9 21:06:03 UTC 2021

On Fri, 9 Apr 2021 19:25:02 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>>   Reflected the review comments.
> src/java.base/share/classes/java/io/Console.java line 404:
>> 402:      *
>> 403:      * @return A {@code Charset} object used in this {@code Console}.
>> 404:      * @since 17
> A couple of minor comments: 
> May replace {@code Charset} with @link;
> Add "the" to the sentence: The returned charset corresponds to "the" input...
> @return: javadoc guide suggests "do not capitalize and do not end with a period" when writing a phrase. But I guess for consistency in this class, it's okay to capitalize.

Thanks, Joe. Modified as suggested.


PR: https://git.openjdk.java.net/jdk/pull/3419

More information about the core-libs-dev mailing list