RFR: 8262108: SimpleDateFormat formatting broken for sq_MK Locale [v5]
naoto at openjdk.java.net
Fri Apr 16 04:22:37 UTC 2021
On Fri, 16 Apr 2021 04:06:54 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review for this proposed fix for https://bugs.openjdk.java.net/browse/JDK-8262108?
>> As noted in a comment in that issue, the bug relates to the return value of `Calendar.getDisplayNames` for the `Calendar.AM_PM` field. The implementation has started returning invalid values for the `AM_PM` field after the "day period" support was added recently in the JDK as part of https://bugs.openjdk.java.net/browse/JDK-8262108.
>> The commit here adds a check in the internal implementation of the display name handling logic, to special case the `AM_PM` field and properly convert the display name array indexes (which is an internal detail) to valid values that represent the `AM_PM` calendar field.
>> The commit also has a new jtreg test case `CalendarDisplayNamesTest` reproduces this issue and verifies the fix.
>> After this fix was introduced, I ran the test in `test/jdk/java/util/Calendar/` and that showed up a failure in an existing test case `NarrowNamesTest`. Looking at that test case, IMO, the current testing in that `NarrowNamesTest` is incorrect and is probably what hid this issue in the first place? To fix this, I have added an additional commit which updates this test case to properly test the `AM_PM` field values.
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> Update existing test based on review comments
Looks good. Thank you for fixing the issue.
Marked as reviewed by naoto (Reviewer).
More information about the core-libs-dev