RFR: 8263154: [macos] DMG builds have finder errors
herrick at openjdk.java.net
Fri Apr 16 16:56:39 UTC 2021
On Thu, 15 Apr 2021 01:24:04 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
> - Issue was reproducible when install-dir points to some invalid location.
> - Fixed by defaulting DMG drag and drop location to /Applications folder and --install-dir will be ignored with warning for DMG.
> - I do not see any way to support other valid, but uncommon locations for drag and drop. For example: /Users/USERNAME/Applications is not possible to support since user name is not known. /usr/bin requires root privileges and should contain symbolic links. Locations which does not exist also not possible to support, since DMG cannot create paths. So /Applications/MyCompany is not possible for DMG.
Since target directory shown by apple script is only a suggestion, and user can drag app to anywhere in finder, I may be able to be convinced to ignore install-dir on dmg builds.
I don't think we should use Log.info() to say given install-dir is ignored, it should just be Log.verbose(). (I started the bad precedence when I used Log.info for messages about foreign app-image, this should have been Log.verbose() too).
More information about the core-libs-dev