RFR: 8264208: Console charset API [v9]
rriggs at openjdk.java.net
Fri Apr 16 18:33:38 UTC 2021
On Thu, 15 Apr 2021 18:29:17 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Please review the changes for the subject issue. This has been suggested in a recent discussion thread for the JEP 400 [(https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. A CSR has also been drafted, and comments are welcome [(https://bugs.openjdk.java.net/browse/JDK-8264209)].
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> Modified javadocs per suggestions.
For the test, can it be re-written in Java.
The direction has been to avoid creating new shell tests as they are fragile.
There are test utilities in ProcessTool to make launching and checking for output very easy.
src/java.base/share/classes/java/io/InputStreamReader.java line 48:
> 46: * <p> For top efficiency, consider wrapping an InputStreamReader within a
> 47: * BufferedReader. For example:
> 48: *
Oddly, none of the reference in this class to the default charset are links to Charset.defaultCharset().
That would be a useful addition, either in the class javadoc or in the 1-arg constructor that uses the default charset.
More information about the core-libs-dev