RFR: 8265421: java/lang/String/StringRepeat.java test is missing a memory requirement [v2]

Christoph Göttschkes cgo at openjdk.java.net
Mon Apr 19 12:50:08 UTC 2021

On Mon, 19 Apr 2021 12:07:21 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Christoph Göttschkes has updated the pull request incrementally with one additional commit since the last revision:
>>   Removes -Xmx2g for the first test case instance, which doesn't require a lot of memory.
> test/jdk/java/lang/String/StringRepeat.java line 27:
>> 25:  * @test
>> 26:  * @summary This exercises String#repeat patterns and limits.
>> 27:  * @run main/othervm -Xmx2g StringRepeat
> So, does `-Xmx2g` make sense in this configuration now?

No, not really. The first test case instance should require way less than 1G of memory, so I will just remove the heap configuration for that instance.


PR: https://git.openjdk.java.net/jdk/pull/3566

More information about the core-libs-dev mailing list